Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reindexing banner #2741

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Add reindexing banner #2741

merged 4 commits into from
Feb 24, 2025

Conversation

DarksightKellar
Copy link
Contributor

@DarksightKellar DarksightKellar commented Feb 24, 2025

Screenshot 2025-02-24 at 17 37 28 Screenshot 2025-02-24 at 17 37 39

Copy link

cloudflare-workers-and-pages bot commented Feb 24, 2025

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79fcb64
Status: ✅  Deploy successful!
Preview URL: https://94d4111d.decent-interface.pages.dev
Branch Preview URL: https://hotfix-app-down-banner.decent-interface.pages.dev

View logs

@adamgall
Copy link
Member

Just looking at the code on my phone right now, but first thought is that the slide effect is probably overkill

@adamgall
Copy link
Member

Can you post some screenshots?

@adamgall
Copy link
Member

@nicolaus-sherrill @parkermccurley @johnqh any suggestions for what the copy should say here?

@DarksightKellar
Copy link
Contributor Author

Just looking at the code on my phone right now, but first thought is that the slide effect is probably overkill

@adamgall lool I know, I know, I just couldn't help it. Doesn't look bad though and meant to be reverted anyway, so

Also, I've updated description with screenshots

@adamgall
Copy link
Member

i think we should put it not on the app home page, but the dao home page. or at the daocontroller level, whatever.

@adamgall
Copy link
Member

Doesn't look bad though

and yeah seeing it in action, the slide is nice

@adamgall adamgall merged commit ccd7724 into main Feb 24, 2025
4 checks passed
@adamgall adamgall deleted the hotfix/app-down-banner branch February 24, 2025 19:43
@adamgall adamgall restored the hotfix/app-down-banner branch February 24, 2025 19:43
@adamgall adamgall deleted the hotfix/app-down-banner branch February 24, 2025 19:44
@adamgall adamgall changed the title Add app down banner Add reindexing banner Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants